parthchandra commented on PR #6377: URL: https://github.com/apache/datafusion-comet/pull/6377#issuecomment-5919290670
The change closes the real gap - jars and native libraries now come from one resolved commit. One latent bug I didn't see raised elsewhere: - **`dev/release/build-release-comet.sh:111`** — in a fresh clone `workdir` doesn't exist (it's gitignored), so `cp "$BUILD_DIR/dev/cargo.config" "$WORKING_DIR"` writes a file called `workdir` rather than placing `cargo.config` inside a directory. It's harmless for the normal Linux-only release because the Dockerfile only does `COPY workdir/cargo.config` in the dormant macOS-SDK stage, but it silently does the wrong thing and would break the macOS build once that path turns on, which is exactly the latent breakage this PR is trying to remove. Please add `mkdir -p "$WORKING_DIR"` right before the copy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
