andygrove commented on code in PR #6451:
URL: https://github.com/apache/datafusion-comet/pull/6451#discussion_r4149555495
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -1815,6 +1815,38 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("regression aggregates fall back to Spark by default") {
Review Comment:
Moved it to `regr_fallback.sql` in 4935e8dd47, with one query per function
so each serde's fallback is checked on its own, and the five imports are gone.
One thing I ran into: under `local[5]` a multi-row `INSERT ... VALUES` writes
one file per row, and single-row partials happen to merge without the error, so
the check passed but the data no longer reproduced the bug. The fixture now
inserts two three-row files with `range(a, b, 1, 1)`, and with the serde change
reverted it fails with the wrong `regr_slope` rather than only a missing
fallback reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
