andygrove commented on PR #6458: URL: https://github.com/apache/datafusion-comet/pull/6458#issuecomment-5921031452
@parthchandra Added in 4101f81d3e: the two-field struct with complementary nullability so both branches need casts, array-of-struct, and structs containing map/array fields. The nested cases cover both branch orders, with `expect_native(if)` and the existing all-THEN, all-ELSE and mixed batches. The expanded `if_nested_nullability` fixture passes locally on Spark 4.1 and 3.5 with a freshly built native library. CI is still running. #6347 merged as fab751c658 and is already included in this branch, so that merge-order prerequisite is satisfied. The mismatched timestamp-label path is unreachable through SQL after #6341/#6345: native `TimestampType` values carry UTC labels even in a non-UTC session. The existing `if_reconciles_timestamp_timezone_labels` Rust test constructs mismatched labels directly and checks mixed, all-THEN and all-ELSE batches. The PR description explains this limitation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
