austin362667 commented on code in PR #12211: URL: https://github.com/apache/datafusion/pull/12211#discussion_r1734316945
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -416,6 +416,50 @@ from data ---- 1 +# csv_query_distance +query R +SELECT distance(c2, c12) FROM aggregate_test_100 +---- +27.565541154252 + +# single_row_query_distance +query R +select distance(sq.column1, sq.column2) from (values (1.1, 2.2)) as sq +---- +1.1 + +# all_nulls_query_distance +query R +with data as ( + select null::int as f, null::int as b + union all + select null::int as f, null::int as b +) +select distance(f, b) +from data +---- +0 Review Comment: Should here be NULL? If so, I will modify the initial value of `sum_of_squares` in accumulator states too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
