1fanwang commented on code in PR #25961:
URL: https://github.com/apache/datafusion/pull/25961#discussion_r4168152393
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -828,6 +828,16 @@ impl<'a> Simplifier<'a> {
}
}
+fn modulo_one_is_zero_type(data_type: &DataType) -> bool {
Review Comment:
Done in
https://github.com/apache/datafusion/commit/79a19bf016dcaaed2aed2eb8305f088581d9f829.
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -828,6 +828,16 @@ impl<'a> Simplifier<'a> {
}
}
+fn modulo_one_is_zero_type(data_type: &DataType) -> bool {
Review Comment:
@2010YOUY01 Done in
https://github.com/apache/datafusion/commit/a11b3a0bfb2ee37a95a843a5e644c98754c48f41.
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -828,6 +828,16 @@ impl<'a> Simplifier<'a> {
}
}
+fn modulo_one_is_zero_type(data_type: &DataType) -> bool {
+ match data_type {
+ DataType::Decimal32(_, scale)
+ | DataType::Decimal64(_, scale)
+ | DataType::Decimal128(_, scale)
+ | DataType::Decimal256(_, scale) => *scale <= 0,
+ data_type => !data_type.is_floating(),
Review Comment:
Done in
https://github.com/apache/datafusion/commit/79a19bf016dcaaed2aed2eb8305f088581d9f829.
It now folds only integer types, as you preferred in the review.
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -828,6 +828,16 @@ impl<'a> Simplifier<'a> {
}
}
+fn modulo_one_is_zero_type(data_type: &DataType) -> bool {
+ match data_type {
+ DataType::Decimal32(_, scale)
+ | DataType::Decimal64(_, scale)
+ | DataType::Decimal128(_, scale)
+ | DataType::Decimal256(_, scale) => *scale <= 0,
+ data_type => !data_type.is_floating(),
Review Comment:
@2010YOUY01 Done in
https://github.com/apache/datafusion/commit/a11b3a0bfb2ee37a95a843a5e644c98754c48f41.
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -828,6 +828,16 @@ impl<'a> Simplifier<'a> {
}
}
+fn modulo_one_is_zero_type(data_type: &DataType) -> bool {
+ match data_type {
+ DataType::Decimal32(_, scale)
Review Comment:
@2010YOUY01 Done in
https://github.com/apache/datafusion/commit/a11b3a0bfb2ee37a95a843a5e644c98754c48f41.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
