Rich-T-kid commented on code in PR #25576:
URL: https://github.com/apache/datafusion/pull/25576#discussion_r4169426380
##########
datafusion/datasource-parquet/src/metadata.rs:
##########
@@ -963,17 +961,14 @@ fn summarize_distinct_counts(
// Return early if there's no chance to reach the required coverage.
let remaining = num_row_groups - row_group_idx - 1;
if ndv_count + remaining < required_count {
- return Precision::Absent;
+ return Ok(Precision::Absent);
}
}
- match max_distinct_count {
- Some(distinct_count) if num_row_groups == 1 => {
- Precision::Exact(distinct_count as usize)
- }
+ Ok(match max_distinct_count {
Review Comment:
> so please state it in the PR description / upgrade notes
will do 👍
> Please also pin it in parquet_ndv_write.slt:
im not sure what this means. im assuming you mean add a regression test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
