andygrove commented on code in PR #881:
URL: https://github.com/apache/datafusion-comet/pull/881#discussion_r1735524730
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -39,10 +42,7 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
import testImplicits._
test("count with aggregation filter") {
- withSQLConf(
- CometConf.COMET_ENABLED.key -> "true",
- CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
- CometConf.COMET_SHUFFLE_MODE.key -> "jvm") {
Review Comment:
Instead of specifying explicit shuffle mode per test, we now run each test
in multiple shuffle modes. See overloaded `test` method at the end of this file
for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
