wudidapaopao commented on PR #25849: URL: https://github.com/apache/datafusion/pull/25849#issuecomment-5983254164
@neilconway Thanks for the suggestion! I tested the aggregate argument caching approach and found that it achieves nearly identical performance. I’ve updated this PR to use the new approach and moved the `COUNT(non-nullable column) → COUNT(1)` rewrite into a separate [PR](https://github.com/apache/datafusion/pull/25990). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
