dwsmith1983 commented on code in PR #5867:
URL: https://github.com/apache/datafusion-comet/pull/5867#discussion_r4186341841
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -925,10 +989,13 @@ object CometArrayPosition extends
CometExpressionSerde[ArrayPosition] with Array
}
}
-object CometArraysZip extends CometExpressionSerde[ArraysZip] {
+object CometArraysZip extends CometExpressionSerde[ArraysZip] with
CodegenDispatchFallback {
Review Comment:
> Please retain genuine Spark fallback for these outputs, including nested
calendar intervals, until the bridge can preserve their full range.
Done in 0e1a2ffe3. `CodegenDispatchFallback` has an opt-in
`dispatchDeclineReason`, checked before any dispatch, and the five serdes this
PR newly routes to the dispatcher (`arrays_zip`, `element_at`, `get_map_value`,
`map_from_arrays`, `array_append`) decline when the result holds a calendar
interval at any depth, so those queries run in Spark as on main. Your query is
a test, along with the interval nested in a struct and as a map value, both the
unsupported and the incompatible routes into the dispatcher, and a control that
still dispatches without an interval. Expressions that main already dispatches,
such as `make_interval` itself, are unchanged; their overflow is #5279.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
