kosiew commented on code in PR #25429:
URL: https://github.com/apache/datafusion/pull/25429#discussion_r4194104437
##########
datafusion/physical-plan/src/lib.rs:
##########
@@ -57,7 +57,7 @@ pub use crate::ordering::InputOrderMode;
pub use crate::sort_pushdown::SortOrderPushdownResult;
pub use crate::statistics::{ChildStats, StatisticsArgs, StatisticsContext};
pub use crate::stream::EmptyRecordBatchStream;
-pub use crate::topk::TopK;
+pub use crate::topk::{TopK, TopKDynamicFilters};
Review Comment:
Could you add a compiling rustdoc example or external integration test that
imports both types from the crate root, constructs `TopKDynamicFilters`, and
passes it to `TopK::try_new`? Tests inside the private `topk` module would
still pass without this re-export, so a public-path compilation test would
catch this visibility issue if it regresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
