github-actions[bot] commented on PR #25530: URL: https://github.com/apache/datafusion/pull/25530#issuecomment-6035068747
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v55.1.0 (current) Built [ 41.077s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.170s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 41.133s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.175s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.655s] 223 checks: 218 pass, 4 fail, 1 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: HashJoinExecBuilder::with_prepared_build, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/hash_join/exec/prepared.rs:313 HashJoinExecBuilder::with_null_aware_value_keys, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/hash_join/exec.rs:586 HashJoinExec::prepare_build, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/hash_join/exec/prepared.rs:154 StatisticsContext::compute_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/statistics.rs:296 StatisticsContext::compute_extended_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/statistics.rs:388 StatisticsContext::compute_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/statistics.rs:296 StatisticsContext::compute_extended_arc, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/statistics.rs:388 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/module_missing.ron Failed in: mod datafusion_physical_plan::joins::key_range_bitmap, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/key_range_bitmap.rs:18 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_missing.ron Failed in: struct datafusion_physical_plan::joins::PreparedHashJoinBuild, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/hash_join/exec/prepared.rs:40 struct datafusion_physical_plan::joins::key_range_bitmap::KeyRangeBitmap, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/key_range_bitmap.rs:52 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/struct_pub_field_missing.ron Failed in: field null_aware_value_keys of struct HashJoinExec, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/ade6fce556fc3cf9ea18014d48fe532012268e7b/datafusion/physical-plan/src/joins/hash_join/exec.rs:1027 --- warning pub_api_sealed_trait_became_unsealed: public API sealed trait became unsealed --- Description: A public API sealed trait has become unsealed, allowing downstream crates to implement it. Reverting this would be a major breaking change. ref: https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/pub_api_sealed_trait_became_unsealed.ron Failed in: trait datafusion_physical_plan::joins::utils::JoinHashMapType in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:105 Summary semver requires new major version: 4 major and 0 minor checks failed Warning produced 0 major and 1 minor level warnings Finished [ 84.988s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
