mohitgurav20 commented on PR #25825: URL: https://github.com/apache/datafusion/pull/25825#issuecomment-6040292369
@kosiew Conflicts are resolved against latest `main`. Summary of the updates: - Merged upstream's `size_of::<Self>()` with `self.map.allocation_size()` in `GroupValuesPrimitive::size()`. - Updated `explain_analyze.slt` (`9.4 KB` -> `10.9 KB`) to reflect the exact memory accounting for single-column primitive aggregation. - Cleaned up the allocation test assertions to keep Codecov patch coverage at 100%. All CI checks are passing now. Ready for another review whenever you have time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
