mohitgurav20 commented on PR #25825: URL: https://github.com/apache/datafusion/pull/25825#issuecomment-6084783924
Thanks for catching that! @kosiew You are completely right that <slt:ignore> on spill_count bypassed the positive-spill check. Since the exact spill_count fluctuates slightly depending on how the hash table footprints are accounted for, I've opted to use your suggestion of using another supported assertion that verifies spilling. I've updated Cases A through F in aggregate_memory_spill.slt to assert against spilled_rows=<slt:ignore>K (mirroring what is already done in Case G). The presence of the K guarantees that the value is > 0 (e.g. 15.0 K), meaning it serves as a strict positive-spill check without being flaky to exact counts. I've pushed the update and all checks should be passing now! Let me know if it looks good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
