andygrove commented on PR #6354: URL: https://github.com/apache/datafusion-comet/pull/6354#issuecomment-6042986186
I've reworked this on top of #5956. Instead of carrying its own truncation rules, the path for a format column now groups the rows by format and runs each group through the literal-format kernel. The Toronto date-level gap @sunchao and @parthchandra found is handled by the `atStartOfDay` gap search from #5956, and @comphead's Havana case is in both DST fixtures. The code those inline comments were on is gone, so they no longer apply. The description has the details and the test results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
