andygrove commented on PR #6354: URL: https://github.com/apache/datafusion-comet/pull/6354#issuecomment-6083079684
Thanks @viirya. The rest of your points are in 97728ba12 too: - The `timestamp_trunc_legacy` doc no longer mentions the row-format path, and it notes the far-future DST difference. - You're right about the fallback and Java's rules. I corrected the description and filed #6816 for far-future DST in native timezone conversions generally, since `hour` and the timestamp casts have the same gap. - I added `run-all-spark-profiles`. - `benches/timestamp_trunc.rs` has a `timestamp_trunc_format_column` group with a single format and mixed formats in UTC and `America/Los_Angeles`, on the same daytime instants I measured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
