devanbenz commented on code in PR #12224:
URL: https://github.com/apache/datafusion/pull/12224#discussion_r1737592576


##########
datafusion/functions/src/string/common.rs:
##########
@@ -418,6 +451,88 @@ impl StringArrayBuilder {
     }
 }
 
+pub(crate) struct LargeStringArrayBuilder {

Review Comment:
   I wanted to make the already existing `StringArrayBuilder` generic but was 
having issues 😢 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to