findepi commented on code in PR #12224: URL: https://github.com/apache/datafusion/pull/12224#discussion_r1738447517
########## datafusion/functions/src/string/concat.rs: ########## @@ -64,13 +66,19 @@ impl ScalarUDFImpl for ConcatFunc { &self.signature } - fn return_type(&self, _arg_types: &[DataType]) -> Result<DataType> { - Ok(Utf8) + fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { + use DataType::*; + Ok(match &arg_types[0] { + Utf8View => Utf8View, + LargeUtf8 => LargeUtf8, + _ => Utf8, + }) Review Comment: > I think the logic is "Whatever the first argument type is the output should be of that type i understand this is what's implemented. but not sure why it is so. what's the exact benefit of presenting the data as string view, if we computed the exact string anyway, and we technically don't need to represent it as a string view? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org