andygrove commented on PR #6691: URL: https://github.com/apache/datafusion-comet/pull/6691#issuecomment-6062253488
The contributor guide changes you asked for are in 5b0705ce9f too. The `spark_comparison` bullet now says it compares the operands as they are: `FLOAT` and `DOUBLE` with `compare_float_arrays` and `compare_float_array_scalar`, and arrays and structs with `spark_comparator`, or `spark_equality` for `=`, `<>`, `<=>` and `IS DISTINCT FROM`. The data filter bullet says that with `spark.comet.parquet.rowFilterPushdown.enabled=true` they compare in Spark's ordering like every other comparison, and the helper table has a row for the two kernels. I also replaced "unwrapped" in the `FloatOperands::Raw` sentence with "as a plain `BinaryExpr`", since neither path wraps the column now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
