andygrove opened a new pull request, #6776: URL: https://github.com/apache/datafusion-comet/pull/6776
## Which issue does this PR close? N/A. Follows the review discussion on #6740. ## Rationale for this change In #6740 the question came up of why the new protobuf flag is named `wrap_second_millisecond_overflow` rather than `spark_420_plus`. The reasoning is worth writing down so contributors and reviewers apply it consistently: - Forks that backport fixes from newer open-source Spark can set a behavior flag from their own shim. - Spark sometimes changes behavior in patch or minor releases, so a version number is a poor proxy for behavior. - Native code stays free of Spark version logic. ## What changes are included in this PR? - `adding_a_new_expression.md`: new "Name the behavior, not the Spark version" subsection under "API Differences Between Spark Versions", including guidance to write comments as "Spark 4.2 and later" when later releases inherit the behavior. - `review-comet-pr` and `review-comet-expression-pr` skills: reviewers flag parameters, proto fields, and comments named for a Spark version instead of the behavior. - `implement-comet-expression` and `wire-datafusion-function` skills: point authors to the new guide section. ## How are these changes tested? Documentation only. Checked with prettier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
