alamb commented on code in PR #25963:
URL: https://github.com/apache/datafusion/pull/25963#discussion_r4223479615
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2837,6 +2837,12 @@ impl Filter {
/// - the `predicate` expression returns a boolean value
/// - the `predicate` expression is not aliased
/// - the `predicate` expression contains no window function calls
+ ///
+ /// # Public Only for Internal Use:
Review Comment:
in fact the comment above says "for internal use in Datafusion only"
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -1408,6 +1408,13 @@ impl HashJoinExec {
/// physical optimizer rule to determine a good join order, which is
/// executed before the `EnforceDistribution` rule (the rule that may
/// insert `RepartitionExec` operators).
+ ///
+ /// # Public Only for Internal Use:
+ ///
+ /// This is not a public API and is for internal use only; see [API
policy] for details.
+ ///
+ /// [API policy]:
https://datafusion.apache.org/contributor-guide/api-health.html#internal-public-apis
+ #[doc(hidden)]
Review Comment:
This one in particular I would like to maybe add a comment about "might
change" or "is tricky to use" if posisble to make it easier to understand the
internal marking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
