geoffreyclaude commented on issue #19241: URL: https://github.com/apache/datafusion/issues/19241#issuecomment-6084677848
@alamb Sorry for the delay, this was trickier than anticipated! I gave it some thought and suggest inverting the two PRs order. First the optimization OR-rewrite, and then the signed zero bug fix. Simply because the signed zero issue is pre-existing and might need a deeper discussion. I've rebased https://github.com/apache/datafusion/pull/25187 and opened it for review. It's not trivial though as the gains depend on the data type: for some we should keep the OR-rewrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
