andygrove commented on PR #6735: URL: https://github.com/apache/datafusion-comet/pull/6735#issuecomment-6087124548
Thanks for checking the paths outside the sort. Both comments are updated in 2c37b8ad76. `nested_float_order_keys.sql` now says strict mode runs those keys natively and points to the strict fixture for that, along with the null orders and RANGE frames that fall back in every mode. `CometWindowGroupLimitExec` now says `CometSortOrder` declines `ASC NULLS LAST` and `DESC NULLS FIRST` on nested keys that can hold a null, in every mode. I also merged `apache/main`, which brings in #6740, so the Spark 4.2 `trunc_timestamp` failure should clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
