dwsmith1983 commented on code in PR #6810:
URL: https://github.com/apache/datafusion-comet/pull/6810#discussion_r4233501472
##########
native/core/src/execution/planner.rs:
##########
@@ -1235,6 +1235,27 @@ impl PhysicalPlanner {
}
}
+ /// Returns a sort of `plan` by the SortOrder exprs in `ordering`, or
`None` when `ordering`
+ /// is empty or the plan's equivalence properties already satisfy it.
+ fn sort_unless_ordered(
Review Comment:
> Could `sort_unless_ordered` take the `PhysicalSortExpr`s, or a
`LexOrdering`, instead of Spark `Expr`s, with the join mapping
`create_sort_expr` at its call site?
Done. The helper takes the physical sort expressions, the hash join maps
`create_sort_expr` where it calls it, and the sort aggregate arm now goes
through the same helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
