asolimando commented on PR #26094: URL: https://github.com/apache/datafusion/pull/26094#issuecomment-6101759186
> @asolimando > > Thanks for the `AggregateStatistics` test. A revert there now fails it (3 vs 42). The `LimitPushdown` half still has no test: with this line back to `StatisticsContext::new()`, every test still passes. A provider `Exact(0)` here removes a limit. The test below passes on this branch and fails under that revert (1 row vs 3). The provider matches `AggregateExec` because a `DataSourceExec` input gets the fetch pushed into the scan, so the limit never reaches this rule. Thanks @jayzhan211! I have added your `LimitPushdown` test as is after checking it, and made sure it fails with that line back to `StatisticsContext::new()` (1 row vs 3). I hope you don't mind me moving both provider tests next to the other tests of each rule (`core/tests/physical_optimizer/aggregate_statistics.rs` and `limit_pushdown.rs`), for consistency with the provider test of `JoinSelection` and `EnforceDistribution`, which are in their respective files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
