Perseus commented on code in PR #47:
URL: https://github.com/apache/datafusion-iceberg/pull/47#discussion_r4241281546
##########
crates/datafusion/tests/integration_datafusion_test.rs:
##########
@@ -475,6 +475,114 @@ async fn test_metadata_table() -> Result<(), Box<dyn
Error>> {
Ok(())
}
+#[tokio::test]
+async fn test_metadata_table_projections() -> Result<(), Box<dyn Error>> {
Review Comment:
I tried to use the new harness for these tests, but it looks like the
metadata tables like `taxi$snapshots` aren't recognized by the catalog because
it doesn't go through the code path
[here](https://github.com/apache/datafusion-iceberg/blob/main/crates/datafusion/src/catalog/schema.rs#L130-L139)
and I see errors like
`...kind: Error, message: "table 'taxi$snapshots' not found", span:
Some(Span(Location(1,23)..Location(1,37))), notes: [], helps: [] }, Plan("table
'datafusion.public.taxi$snapshots' not found"))`
It looks like the way to solve this is to use iceberg's
`MemoryCatalogBuilder`, and register the `taxi` table through that, so queries
are able to resolve metadata tables.
If that change makes sense to you, I can add that to this PR, or open a
separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
