Perseus commented on code in PR #47:
URL: https://github.com/apache/datafusion-iceberg/pull/47#discussion_r4200070117
##########
crates/datafusion/src/physical_plan/metadata_scan.rs:
##########
@@ -19,39 +19,44 @@ use std::sync::Arc;
use datafusion::catalog::TableProvider;
use datafusion::common::tree_node::TreeNodeRecursion;
+use datafusion::error::Result;
use datafusion::physical_expr::{EquivalenceProperties, PhysicalExpr};
use datafusion::physical_plan::execution_plan::{Boundedness, EmissionType};
use datafusion::physical_plan::stream::RecordBatchStreamAdapter;
use datafusion::physical_plan::{DisplayAs, ExecutionPlan, Partitioning,
PlanProperties};
-use futures::TryStreamExt;
+use futures::{StreamExt, TryStreamExt};
use crate::metadata_table::IcebergMetadataTableProvider;
-/// Scans an Iceberg metadata table, such as `$snapshots`.
#[derive(Debug)]
pub struct IcebergMetadataScan {
provider: IcebergMetadataTableProvider,
properties: Arc<PlanProperties>,
+ projection: Option<Vec<usize>>,
}
impl IcebergMetadataScan {
- /// Creates a scan of the metadata table `provider` reads.
- pub fn new(provider: IcebergMetadataTableProvider) -> Self {
+ pub fn try_new(
Review Comment:
It seems like its idiomatic Rust to use `try_*` if the fn returns a
`Result`, so I renamed/refactored this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
