alamb commented on code in PR #12008: URL: https://github.com/apache/datafusion/pull/12008#discussion_r1740726312
########## .github/workflows/rust.yml: ########## @@ -39,6 +39,14 @@ on: workflow_dispatch: jobs: + # Check license header + license-header-check: + runs-on: ubuntu-20.04 + name: Check License Header + steps: + - uses: actions/checkout@v4 + - uses: korandoru/hawkeye@v5 Review Comment: I am not sure about license / workflow. the run-rat.sh setup came from the https://github.com/apache/arrow repo when we broke arrow-rs and datafusion out into their own repos. I haven't followed any changes in the arrow repo since then I don't personally have any preference about the mechanism of checking licenses as long as it is done. I do think it is important that whatever CI uses is consistent with creating the release tarballs so we don't interfere with creating new releases: https://github.com/apache/datafusion/blob/4838cfbf453f3c21d9c5a84f9577329dd78aa763/dev/release/create-tarball.sh#L120-L121 (perhaps this just means removing the explicit additional check for licenses when creating release tarballs, as they are redundant with the checks done on ci 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
