devanbenz commented on PR #12224: URL: https://github.com/apache/datafusion/pull/12224#issuecomment-2324820327
> Thank you @devanbenz @findepi and @tshauck > > I think this PR is good enough to merge, but I agree with @devanbenz 's observation [#12224 (files)](https://github.com/apache/datafusion/pull/12224/files#r1740156822) that StringViewArrayBuilder feels hacky. > > Specifically I think what is happening is that `StringArrayBuilder` is for a pretty specialized usecase, and thus so is `StringViewArrayBuilder` > > I filed [apache/arrow-rs#6347](https://github.com/apache/arrow-rs/issues/6347) upstream with a description of the use case to see if we can come up with something more general Great sounds good @alamb 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
