kosiew commented on code in PR #25802:
URL: https://github.com/apache/datafusion/pull/25802#discussion_r4323321704
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -651,6 +651,10 @@ impl FileSource for ParquetSource {
enable_row_group_stats_pruning:
self.table_parquet_options.global.pruning,
coerce_int96,
coerce_int96_tz,
+ coerce_binary_to_string: self
Review Comment:
The new tests set this flag directly on the private morselizer builder, so
they wouldn't catch a regression in the configuration path through
`ParquetSource`. Could we add a public scan test that disables the option
through session configuration and checks that valid binary values become
strings while invalid UTF-8 produces the expected cast error? It could also use
a custom adapter to verify replacement behavior if convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
