pingzh opened a new issue, #7144: URL: https://github.com/apache/datafusion-comet/issues/7144
### What is the problem the feature request solves? The SQL-level `make_date` projection and aggregate regressions added by #7117 live in `CometExecRuleSuite`. Move their SQL inputs, answer comparisons, and fallback expectations into focused fixtures next to `make_date_overflow.sql`, retaining any assertions that require Scala. This is test organization work; the current regressions already exercise the behavior. ### Describe the potential solution - Move `make_date remains deferred across conditional projections` and `make_date aggregate arguments retain Spark execution` into the datetime SQL fixtures, removing redundant Scala execution coverage only after equivalent assertions are in place. - Preserve the projection cases for `IF`, `COALESCE`, nullable-left `datediff`, and the eager native `date_add` control with an unrelated conditional. Keep materialized overflow input, `rand(7L)`, whole-stage codegen enabled, and AQE false/true coverage. - Set `-- ConstantFolding: enabled` for the projection fixture. The SQL runner disables constant folding by default, whereas the current regression exercises the default optimizer. - Preserve the `below PROJECT`, `in HashAggregate`, and `in ObjectHashAggregate` fallback reasons, aggregate `FILTER` cases, and native execution controls. Use the relevant configuration per fixture rather than multiplying unrelated test matrices. - Keep focused Scala assertions where exact operator counts or native-scan retention are important. Synthetic-plan, RDD, `mapPartitions`, and empty-`IN` tests that need Scala stay there. - Validate the moved fixtures across applicable Spark profiles before removing the old coverage. ### Additional context Follow-up to [the review on #7117](https://github.com/apache/datafusion-comet/pull/7117#discussion_r4332013638). Related to #6625, which covers datetime migration from `CometTemporalExpressionSuite` and `CometExpressionSuite`. This issue scopes the new `CometExecRuleSuite` regressions introduced by #7117. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
