tanmay442 commented on PR #26536: URL: https://github.com/apache/datafusion/pull/26536#issuecomment-6310595695
A note on what changing the approach would mean, since I promised it above. A batch touches at most as many groups as it has rows, so when the group count is below the row count the word-at-a-time scan of the scoreboard is the cheaper path. Choosing between the two would be one comparison at the top of the function rather than a rewrite. Whether that is worth two paths, for a percent or two in one shape against the win in the other, is a call to make with the measurement in hand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
