geoffreyclaude commented on code in PR #26242:
URL: https://github.com/apache/datafusion/pull/26242#discussion_r4335376747
##########
datafusion/physical-plan/src/sorts/sort/spill_tests.rs:
##########
@@ -533,6 +543,155 @@ async fn
test_chunked_string_view_spill_can_use_workspace() -> Result<()> {
check_chunked_string_view_workspace(true).await
}
+/// Prepared runs retain their workspace loans until merging starts. Looking
+/// ahead during the merge returns enough workspace for its batch and cursors.
+async fn check_sort_preparation_workspace(consume_output: bool) -> Result<()> {
Review Comment:
Added `sort_preparation_restores_run_order` in
00cf3cdab10f6c27ec47cb045984992d3c4fb6fe. It supplies completed runs in reverse
order and checks their original order is restored, with distinct payloads for
equal keys. This avoids relying on batch sizes or timing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
