jprochazk opened a new issue, #26559:
URL: https://github.com/apache/datafusion/issues/26559

   ### Is your feature request related to a problem or challenge?
   
   datafusion-ffi has `crate-type = ["cdylib", "rlib"]`, but the `cdylib` is 
only used by its own integration tests. Every downstream build still compiles 
and links it, even when it's unused.
   
   We use `sccache` on CI, and it considers `rustc` invocations with 
`crate-type=cdylib` non-cacheable. `cargo` invokes `rustc` with both crate 
types in one call, so this means the `rlib` is also not cached. This means 
`datafusion-ffi` is rebuilt from scratch each time.
   
   ### Describe the solution you'd like
   
   Move `datafusion/ffi/tests/` into a new unpublished crate (e.g. 
`datafusion-ffi-integration-tests`) that is built as a `cdylib` and re-exports 
the `#[no_mangle]` test entry points from `datafusion_ffi::tests`. 
`datafusion-ffi` becomes a plain `rlib`, with no change to its public API or 
ABI.
   
   ### Describe alternatives you've considered
   
   Keeping the tests in place with a `cdylib`-only `dev-dependency` works, but 
Cargo warns that this "might turn into a hard error in the future".
   
   ### Additional context
   
   The `cdylib` crate type was added in #13937. There don't seem to be other 
users of it. It is still possible to build as `cdylib` as a user even if 
`datafusion-ffi` itself is not declared a `cdylib`.
   
   ### Willingness to contribute
   
   I plan to contribute to this feature independently


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to