Rich-T-kid commented on code in PR #26191:
URL: https://github.com/apache/datafusion/pull/26191#discussion_r4337426213
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -321,15 +321,9 @@ fn hash_array_primitive<T>(
if array.null_count() == 0 {
if rehash {
- for (hash, &value) in
hashes_buffer.iter_mut().zip(array.values().iter()) {
- let mut hasher =
random_state.seeded_state(*hash).build_hasher();
- value.hash_write(&mut hasher);
- *hash = hasher.finish();
- }
+ hash_prim_rehash_dense(array.values(), hashes_buffer,
random_state);
Review Comment:
I think its fine to leave this out of the pr since this is purely perf
focused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
