neilconway opened a new pull request, #26571: URL: https://github.com/apache/datafusion/pull/26571
When the shared ubuntu-latest pool is saturated, required checks that need only a minute of work can wait hours to start. ubuntu-slim jobs start within minutes at those times: ASF Infrastructure recommends slim for small jobs because they "bypass the standard ubuntu-latest queue". In 80 recent rust.yml runs, the slim job "Check datafusion crates used in datafusion-examples" waited 4.2 minutes at the 90th percentile, while "Check cargo fmt", created at the same moment, waited 114 minutes. Move these jobs to ubuntu-slim: - rust.yml: Check cargo fmt, Check GitHub Actions install tooling, check Cargo.toml formatting, Verify Vendored Code - dev.yml: Check License Header, Check Markdown Links, Validate required_status_checks in .asf.yaml, Spell Check with Typos - dependencies.yml: Detect Unused Dependencies - audit.yml: security_audit - docs_pr.yaml: Test doc build - breaking_changes_detector_comment.yml: Comment on pull request For a pull request from a fork, every required check that upstream runs is now on slim except Circular Dependency Check. Slim has no Docker engine, so the jobs that ran in the amd64/rust container now run directly on the runner. Slim also has no Rust, so the new setup-rustup action installs rustup and then the toolchain that rust-toolchain.toml pins. That is less work than the container jobs did: they pulled the amd64/rust image, installed the latest stable toolchain, which rust-toolchain.toml then overrides, installed the pinned toolchain, and (in the fmt job) spent about 40 seconds deleting preinstalled software. The Cargo.toml formatting job runs only taplo, so it no longer installs Rust at all. The vendor job installs protoc with apt, which setup-builder used to do. Slim has one vCPU, 5 GB of memory, and a 15-minute job limit, so jobs that compile much of the workspace stay where they are: MSRV, the common, functions, and spark feature checks, the examples README check, wasm-pack, the circular dependency check, and the semver check. The docs deploy job also stays, because only a merge to main can test it. The rust.yml header and the contributor guide now describe when a job runs on slim. > [!IMPORTANT] > > **Fork CI setup:** For pull requests from a fork to `main`, enable workflows in your fork's **Actions** tab before you push. > See the [fork CI setup guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks). ## Which issue does this PR close? - N/A ## Rationale for this change The `ubuntu-latest` ASF runner pool is perpetually overloaded. [ASF Infra recommends using the `ubuntu-slim` image instead](https://infra.apache.org/services.html): > Use lightweight runners: For small, short jobs, consider using runs-on: ubuntu-slim. These provide 1 vCPU, 5GB RAM, no Docker engine, and a 15-minute hard limit. They churn much more quickly during peak times, allowing you to bypass the standard ubuntu-latest queue while freeing up capacity for others. This PR moves the following CI jobs to use `ubuntu-slim`: - `rust.yml`: Check cargo fmt, Check GitHub Actions install tooling, check Cargo.toml formatting, Verify Vendored Code - `dev.yml`: Check License Header, Check Markdown Links, Validate required_status_checks in .asf.yaml, Spell Check with Typos - `dependencies.yml`: Detect Unused Dependencies - `audit.yml`: security_audit - `docs_pr.yaml`: Test doc build - `breaking_changes_detector_comment.yml`: Comment on pull request <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the implementation. "COUNT(DISTINCT) returns wrong results when the column contains nulls" is the user-visible problem. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> ## What is the testing strategy for this PR? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'. If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it. You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised. --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
