kumarUjjawal opened a new pull request, #26591:
URL: https://github.com/apache/datafusion/pull/26591

   ## Which issue does this PR close?
   
   Related to #26181 and the CI follow-up requested in 
https://github.com/apache/datafusion/pull/26189#issuecomment-6300780959.
   
   Depends on #26590. This branch includes its prerequisite fix; the new CI 
commit changes only `.github/workflows/rust.yml`. Rebase after #26590 merges to 
remove that prerequisite from the diff.
   
   ## Rationale for this change
   
   CI currently runs Clippy with `avro,integration-tests,extended_tests`, which 
missed the Arrow buffer-pool lint failures exposed by `--all-features`.
   
   Keep that existing check as well: `force_hash_collisions` disables normal 
hashing code when all features are enabled, so the two configurations cover 
different code.
   
   ## What changes are included in this PR?
   
   Add `cargo clippy --workspace --all-targets --all-features -- -D warnings` 
after the current Clippy step. Both steps use the existing Linux job, build 
setup, cache, and required check. Fork and merge-queue job conditions remain 
unchanged.
   
   ## What is the testing strategy for this PR?
   
   Local checks passed:
   
   - Both Clippy commands, including the exact new workflow command.
   - `cargo fmt --all`, `git diff --check`, and `uv run ./dev/rust_lint.sh`.
   - Required-check and workflow skip-policy validators, 4 Python tests, and 24 
fork CI tests.
   - The required extended workspace test command: 12,819 Rust tests passed, 8 
ignored, and all 538 SQL logic test files completed.
   
   Hosted Linux validation is pending. The new step itself checks the 
additional feature configuration; no runtime tests were added for this 
workflow-only change.
   
   ## Are there any user-facing changes?
   
   No SQL behavior or API changes. CI now also rejects Clippy warnings exposed 
by the all-features configuration.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to