alamb commented on code in PR #26591:
URL: https://github.com/apache/datafusion/pull/26591#discussion_r4361304282
##########
.github/workflows/rust.yml:
##########
@@ -837,6 +837,11 @@ jobs:
shared-key: "amd-ci-clippy"
- name: Run clippy
run: ci/scripts/rust_clippy.sh
+ - name: Install CMake
+ # The all-features check builds snmalloc-sys, which requires CMake.
+ run: apt-get install -y --no-install-recommends cmake
+ - name: Run clippy with all features
+ run: cargo clippy --workspace --all-targets --all-features -- -D
warnings
Review Comment:
It seems like maybe we should put this command in
`ci/scripts/rust_clippy.sh` or whatever it calls so that it will be invoked by
local agents / people too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
