morristai opened a new pull request, #26635: URL: https://github.com/apache/datafusion/pull/26635
## Which issue does this PR close? - Closes #26633. ## Rationale for this change There is no way to tell which reader factory a `ParquetSource` uses. `parquet_file_reader_factory()` returns `&Arc<dyn ParquetFileReaderFactory>`, and the trait has no downcast path. ## What changes are included in this PR? `ParquetFileReaderFactory` gets `Any` as a supertrait, and `dyn ParquetFileReaderFactory` gets `is` and `downcast_ref`, like `dyn FileSource` in #21576. I also added a 56.0.0 upgrade guide entry, like the ones for `MemoryPool` (#21803) and `QueryPlanner` (#22241). ## What is the testing strategy for this PR? A unit test in `source.rs` sets each built-in factory on a `ParquetSource` and checks that `parquet_file_reader_factory()` downcasts to it. ## Are there any user-facing changes? Two new methods on `dyn ParquetFileReaderFactory`. The semver check will flag the new supertrait, but the trait already required `'static`, so existing implementations compile unchanged. Drafted with Claude. I reviewed the change and this text. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
