Blizzara commented on code in PR #12245:
URL: https://github.com/apache/datafusion/pull/12245#discussion_r1745686032
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -657,7 +662,13 @@ pub async fn from_substrait_rel(
table: nt.names[2].clone().into(),
},
};
- let t = ctx.table(table_reference).await?;
+
+ let substrait_schema =
+ from_substrait_named_struct(named_struct, extensions)?
+ .replace_qualifier(table_reference.clone());
+
+ let t = ctx.table(table_reference.clone()).await?;
+ let t = ensure_schema_compatability(t, substrait_schema)?;
Review Comment:
we should maybe add this for the local file reads below as well (I didn't
have it in my branch yet as I didn't need it immediately). Somewhat annoyingly
it'll cause the rest of the TPCH tests to fail...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
