Blizzara commented on PR #12245: URL: https://github.com/apache/datafusion/pull/12245#issuecomment-2334710029
I think this is good by me - @alamb would you (or someone else) be able to do the official review, please? :) Only note I have is that I think this change makes Substrait consumer case-sensitive wrt column names, which it wasn't before. I don't strictly have opinion on whether that's a good or a bad thing. I think for _my_ usecase it would be fine, but dunno about others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
