Abhishek-Mohan opened a new pull request, #7164:
URL: https://github.com/apache/datafusion-comet/pull/7164
## Which issue does this PR close?
Part of #4419.
## Rationale for this change
#4650 rewrote this page. A few uses of "native" are left, mostly in the
explain section and the operator tables. The rule IDs refer to the style guide
in #7151.
## What changes are included in this PR?
- **"native" now says what is meant (N1):** "Rust" where the text means the
Rust implementation or the Rust plan, and "in the Comet pipeline" where it
means Comet as a whole. Examples:
- "runs natively in DataFusion"
- "lowered to native DataFusion expressions"
- "own native plan"
- **"Spark's native shuffle" → "Spark's built-in shuffle" (N5).**
- **Unchanged:**
- the three kinds of nodes;
- "native shuffle" and the "Native Rust Operators" heading (N2);
- config keys, API names, and quoted explain output (N6).
- **prettier realigns the Scans table** because two of its rows changed.
**Not changed, needs a follow-up:** the `from_unixtime` example under
"Programmatic Access to Fallback Reasons" is out of date. `CometFromUnixTime`
now mixes in `CodegenDispatchFallback` (`unixtime.scala:29`), so that query
stays in `CometProject` through codegen dispatch instead of falling back. The
example needs real explain output from a current build, or a different
expression that still falls back. I'd rather not invent output, so I'll handle
it separately.
## How are these changes tested?
Docs only.
- `prettier --check` passes.
- I built the docs locally with Sphinx.
AI assistance: OpenCode helped check the page against the code and draft the
edits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
