sunchao commented on code in PR #7123: URL: https://github.com/apache/datafusion-comet/pull/7123#discussion_r4357346660
########## spark/src/test/scala/org/apache/comet/CometBroadcastBuildSideSuite.scala: ########## @@ -19,20 +19,31 @@ package org.apache.comet -import org.apache.spark.sql.CometTestBase +import java.io.File +import java.nio.charset.StandardCharsets.UTF_8 +import java.nio.file.Files + +import org.apache.spark.SparkConf Review Comment: [P2] [P2] Remove the unused `SparkConf` import. This revision removes the suite’s `sparkConf` override, leaving this import without a use. All six exact-head Java-lint jobs now fail Scalafix, and compiling the suite with unused-import warnings promoted to errors also fails. The build should remain compilable after the override is removed. Please drop this import so the required checks can pass. Evidence: Exact-head Spark 4.2 CI ran `./mvnw -B package -DskipTests scalafix:scalafix -Dscalafix.mode=CHECK -Psemanticdb -Pspark-4.2` and proposed removing precisely `import org.apache.spark.SparkConf` before failing: https://github.com/apache/datafusion-comet/actions/runs/39919227954/job/120301609004. The other five Java-lint logs show the same removal. Local Scala 2.13.17 compilation of the exact suite with `-Ywarn-unused:imports -Xfatal-warnings` exited 1 with `CometBroadcastBuildSideSuite.scala:26: warning: Unused import`. A disposable copy removing only that line compiled successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
