sunchao commented on code in PR #7148: URL: https://github.com/apache/datafusion-comet/pull/7148#discussion_r4363995494
########## native/core/src/parquet/mod.rs: ########## @@ -26,5 +26,7 @@ pub mod util; mod cast_column; mod datetime_rebase; mod field_resolver; +mod footer_rewrite; Review Comment: [P1] Include the missing `footer_rewrite` module. This unconditional declaration has neither a `footer_rewrite.rs` nor a `footer_rewrite/mod.rs` in the commit, while `datetime_rebase.rs`, `eager_page_index_reader_factory.rs`, and `int96_coercion.rs` now import its `with_key_values` function. A clean checkout therefore cannot build the native crate, regardless of the input or scan configuration. Please commit the helper implementation or restore the previous footer rebuilds. Evidence: Both the local Git tree and GitHub's tree for aa9479b81efb21eb5d5b39ec66e0ad3bce1de427 contain no footer_rewrite module. Running `cd native && cargo fmt --all -- --check` exits 1 with `failed to resolve mod footer_rewrite: .../native/core/src/parquet/footer_rewrite.rs does not exist`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
