sam-1112 commented on PR #5835: URL: https://github.com/apache/datafusion-comet/pull/5835#issuecomment-6375570195
Thanks @rich7420 , good point. I removed the foldability check so `sha2(payload, numBits)` stays fully native through `SparkSha2`. I also added BINARY payload coverage for the same `num_bits` values, including invalid values and NULL. The tests assert native execution with no dispatcher activity whether codegen dispatch is enabled or disabled. All 3 focused SHA-2 tests passed on Spark 3.5/4.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
