timsaucer opened a new pull request, #859:
URL: https://github.com/apache/datafusion-python/pull/859
# Which issue does this PR close?
Closes #780
# Rationale for this change
This PR follows the same pattern as the recently closed #808 but does the
same for aggregate functions. This is a usability enhancement.
# What changes are included in this PR?
This PR updates the signatures for the aggregate functions to take optional
parameters for the following:
- order_by
- distinct
- null_treatment
- filter
We add these parameters to the aggregate functions based on which ones are
used internally. The other options are not in the function call. Users can
always add these using the builder function approach if any of the internals
get updated at a later time.
# Are there any user-facing changes?
TODO : Review all APIs and document any that are removals or alterations
Remaining functions to update (author tracking purpose):
- [ ] array_agg
- [ ] avg
- [ ] bit_and
- [ ] bit_or
- [ ] bit_xor
- [ ] bool_and
- [ ] bool_or
- [ ] corr
- [ ] count
- [ ] covar_samp
- [ ] covar_pop
- [ ] last_value
- [ ] first_value
- [ ] grouping
- [ ] median
- [ ] Min
- [ ] Max
- [ ] nth_value
- [ ] regr_slope
- [ ] regr_intercept
- [ ] regr_count
- [ ] regr_r2
- [ ] regr_avgx
- [ ] regr_avgy
- [ ] regr_sxx
- [ ] regr_syy
- [ ] regr_sxy
- [ ] stddev
- [ ] stddev_pop
- [ ] string_agg
- [ ] sum
- [ ] var_sample
- [ ] var_pop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
