comphead commented on issue #26700: URL: https://github.com/apache/datafusion/issues/26700#issuecomment-6380240125
These are the `slt` files to amend, grouped by operator. Paths are relative to `datafusion/sqllogictest/test_files/`. Markers: - **E**: the file contains `EXPLAIN`, so it needs a plan/matrix split (or the runner has to skip `EXPLAIN` for non-default sizes). - **S**: the file sets `datafusion.execution.batch_size` itself, so that `SET` has to be removed or reconciled with the sweep. ### Aggregation - [ ] `aggregate.slt` (E) - [ ] `aggregate_any_value.slt` - [ ] `aggregate_filter_selection.slt` (S) - [ ] `aggregate_memory_spill.slt` (E, S) - [ ] `aggregate_repartition.slt` (E) - [ ] `aggregate_skip_partial.slt` - [ ] `aggregates_topk.slt` (E) - [ ] `array_agg.slt` (E) - [ ] `distinct_on.slt` (E) - [ ] `first_last_nested.slt` - [ ] `first_last_ordered.slt` - [ ] `group.slt` - [ ] `group_by.slt` (E) - [ ] `grouping.slt` (E) - [ ] `grouping_set_repartition.slt` (E) - [ ] `ordered_aggregate_key_types.slt` (E, S) - [ ] `ordered_aggregate_spill.slt` (E, S) - [ ] `range_sorted_time_bin_agg.slt` (E) - [ ] `single_distinct_to_groupby.slt` (E) - [ ] `min_max/*.slt` - [ ] `spark/aggregate/avg.slt`, `spark/aggregate/collect.slt`, `spark/aggregate/try_sum.slt` ### Windows - [ ] `window.slt` (E, S) - [ ] `window_limits.slt` (E) - [ ] `window_topk_pushdown.slt` (E) - [ ] `window_topn.slt` (E) - [ ] `array_agg_sliding_window.slt` - [ ] `lead_lag_extreme_offsets.slt` - [ ] `qualify.slt` (E) - [ ] `pg_compat/pg_compat_window.slt` - [ ] `spark/aggregate/collect_window.slt` ### Joins - [ ] `joins.slt` (E) - [ ] `join.slt.part` (E), included by `join_only.slt` and `join_disable_repartition_joins.slt` (E) - [ ] `join_is_not_distinct_from.slt` (E) - [ ] `join_limit_pushdown.slt` (E) - [ ] `join_lists.slt` - [ ] `join_dynamic_filter_transfer.slt` (E) - [ ] `joins_conditionless.slt` - [ ] `same_column_name_cross_join.slt` - [ ] `asof_join.slt` (E) - [ ] `lateral_join.slt` (E) - [ ] `sort_merge_join.slt` (E) - [ ] `sort_merge_join_batches.slt` (E, S) - [ ] `sort_merge_join_spill.slt` (E, S) - [ ] `pwmj.slt` (E) - [ ] `piecewise_merge_join_batches.slt` (E, S) - [ ] `nested_loop_join_existence.slt` (E, S) - [ ] `nested_loop_join_lambda.slt` (E) - [ ] `nested_loop_join_spill.slt` (E, S) - [ ] `null_aware_anti_join.slt` (E, S) - [ ] `null_aware_mark_join.slt` (E, S) These files already sweep `batch_size` with `configMatrix`: `sort_merge_join_matrix.slt`, `piecewise_merge_join_matrix.slt`, `piecewise_merge_join_nested_nulls.slt`, `mark_join_matrix.slt`, `null_aware_multi_column.slt`. ### Limits, TopK and sort - [ ] `limit.slt` (E) - [ ] `limit_single_row_batches.slt` - [ ] `limit_pruning.slt` (E) - [ ] `topk.slt` (E) - [ ] `push_down_topk_through_join.slt` (E) - [ ] `order.slt` (E) - [ ] `order_by_all.slt` - [ ] `sort_pushdown.slt` (E) - [ ] `subquery_sort.slt` (E) ### Set operations - [ ] `union.slt` (E, S) - [ ] `union_by_name.slt` - [ ] `intersection.slt` - [ ] `pg_compat/pg_compat_union.slt` ### Unnest and generators - [ ] `unnest.slt` (E) - [ ] `unnest_struct_nulls.slt` - [ ] `push_down_filter_unnest.slt` (E) - [ ] `spark/generator/stack.slt` ### Recursive CTE and subqueries - [ ] `cte.slt` (E, S) - [ ] `cte_materialized.slt` (E) - [ ] `subquery.slt` (E, S) - [ ] `subquery_projection.slt` (E) ### Repartition - [ ] `repartition.slt` (E) - [ ] `repartition_scan.slt` (E) - [ ] `range_partitioning.slt` (E) ### End-to-end query suites - [ ] `tpch/tpch.slt`, which includes `tpch/answers/*.slt.part` (no `EXPLAIN`) and `tpch/plans/*.slt.part` (E) - [ ] `clickbench.slt` (E) - [ ] `imdb.slt` I left out files that mainly test scalar functions, casts, DDL/DML, optimizer rewrites or file formats. Their results are not expected to depend on how batches are split, but I have not checked this. With the runner-flag approach from the description, they would be swept anyway, at no extra editing cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
