pepijnve commented on code in PR #25887:
URL: https://github.com/apache/datafusion/pull/25887#discussion_r4368363868
##########
datafusion/catalog/src/information_schema.rs:
##########
@@ -150,6 +202,17 @@ impl InformationSchemaConfig {
}
}
+ if let Some(system_catalog_name) = &self.system_catalog_name {
+ for table_name in INFORMATION_SCHEMA_TABLES {
+ builder.add_table(
Review Comment:
I've added an extra guard to avoid duplicates. I think I might reconsider
this 'system catalog' idea in the followup where all the SQL stuff disappears.
I can get away with a simpler global/partitioned toggle there.
##########
datafusion/sql/src/statement.rs:
##########
Review Comment:
Fixed
##########
datafusion/sql/src/statement.rs:
##########
Review Comment:
Fixed
##########
datafusion/sql/src/statement.rs:
##########
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
