pepijnve commented on PR #25887: URL: https://github.com/apache/datafusion/pull/25887#issuecomment-6395929392
@alamb while working through @martin-g's review comments I came to the realisation that in the followup #26057 PR we can drop the 'system catalog' concept entirely. That was only really necessary to support a partitioned information schema at the table level, but still allow the `SHOW` statements to report global results. In the referenced PR, the `SHOW` statements are no longer implemented as SQL queries so the need disappears. I've gone ahead and removed the concept in #26057. This PR is then an intermediate step. I'm not sure what the best approach is here. On the one hand I think it would be easiest from a review point-of-view to merge this work already, and then make sure that the other PR is merged before the next release ships. On the other hand, that does put some timing pressure on the review. If we want to avoid that it might be better to consolidate the two PRs and merge the work in one go. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
