princejain756 commented on PR #26699: URL: https://github.com/apache/datafusion/pull/26699#issuecomment-6393339637
Thanks for the review and for catching the `Join` above a pulled-up groupless scalar aggregate case, @jayzhan211! Addressed in 320f268: 1. Stopped pull-up (`self.can_pull_up = false` + `TreeNodeRecursion::Stop`) at `LogicalPlan::Join(_)` and `LogicalPlan::AsOfJoin(_)` when `self.pulled_up_scalar_agg` is set, and added the 3 `EXISTS` / `IN` test cases to `subquery.slt`. 2. Updated the `subquery.slt` regression block to test the outer-shadowed `t2 AS s` `EXISTS` query and the `SELECT b` `CROSS JOIN LATERAL` query from #26692 directly. 3. Added `#[deprecated(since = "56.0.0", ...)]` to `correlated_subquery_cols_map` and `collected_count_expr_map` (with `#[expect(deprecated)]` on internal writes) and updated the doc comment on `collected_count_expr_map`. 4. Replaced `self.pulled_up_frames.pop().unwrap_or_default()` with an `internal_err!` check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
