goutamadwant commented on code in PR #25816:
URL: https://github.com/apache/datafusion/pull/25816#discussion_r4372279079
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -1441,9 +1489,20 @@ fn coerce_window_frame(
}
WindowFrameUnits::Rows | WindowFrameUnits::Groups => DataType::UInt64,
};
- window_frame.start_bound =
- coerce_frame_bound(&target_type, window_frame.start_bound)?;
- window_frame.end_bound = coerce_frame_bound(&target_type,
window_frame.end_bound)?;
+ let original_start = window_frame.start_bound.clone();
+ let original_end = window_frame.end_bound.clone();
+ window_frame.start_bound = coerce_frame_bound(&target_type,
original_start.clone())?;
Review Comment:
done @kosiew coercion now consumes the original bounds directly. The saved
copies remain only for pre-coercion sign validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
